Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2 version of GotoDefinitionService #2168

Merged
merged 7 commits into from May 31, 2021

Conversation

@333fred
Copy link
Contributor

@333fred 333fred commented May 30, 2021

The V1 GotoDefinitionService can only return one definition for a symbol. This is particularly annoying for partial types, which have multiple locations, and the location the service returns is pretty much never the one I want. The V2 service is very similar, but it uses V2 location models and returns a list of definitions, not a single one.

333fred added 2 commits May 30, 2021
The V1 GotoDefinitionService can only return one definition for a symbol. This is particularly annoying for partial types, which have multiple locations, and the location the service returns is pretty much never the one I want. The V2 service is very similar, but it uses V2 location models and returns a list of definitions, not a single one.
@333fred
Copy link
Contributor Author

@333fred 333fred commented May 30, 2021

@filipw @david-driscoll could you take a look?

Copy link
Member

@filipw filipw left a comment

Thank, you this is a very good idea - I left some small comments only

@333fred
Copy link
Contributor Author

@333fred 333fred commented May 30, 2021

@filipw addressed your feedback, thanks.

filipw
filipw approved these changes May 30, 2021
Copy link
Member

@filipw filipw left a comment

thanks!

@@ -260,7 +260,7 @@ private static async Task<CodeElement> TranslateAsync(this CodeElement element,
continue;
}

builder.AddChild(childElement);
builder.AddChild(translatedElement);
Copy link
Contributor Author

@333fred 333fred May 30, 2021

This only ever worked because mutation.

Copy link
Member

@filipw filipw May 31, 2021

🙈

@filipw filipw merged commit 8a23df3 into OmniSharp:master May 31, 2021
16 checks passed
@333fred 333fred deleted the find-multiple-symbols branch May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants