Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defend against null value in BuildErrorEventArgs #2172

Merged
merged 1 commit into from Jun 7, 2021
Merged

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jun 4, 2021

Resolves #2171

Looking at the deserialize code for BuildErrorEventArgs and it appears that null is a valid value for the Code property - https://github.com/dotnet/msbuild/blob/206d7ae3e6187e2d214041bf79719600ec197c56/src/Framework/BuildErrorEventArgs.cs#L300

filipw
filipw approved these changes Jun 4, 2021
Copy link
Member

@filipw filipw left a comment

that is new to me 🧐

@filipw filipw merged commit 5b7fe24 into master Jun 7, 2021
16 checks passed
@filipw filipw deleted the avoid-null-reference branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants