Add support for ssl connection #10

Open
wants to merge 15 commits into
from

Projects

None yet

4 participants

@marcelloceschia

No description provided.

marcello.ces... and others added some commits May 28, 2012
marcello.ceschia start with ssl implementation cde00ab
marcello.ceschia add ssl notice to README 35d07ed
marcello.ceschia first working version 7cc5d46
Duncan Burke Added support for arbitrary headers and setting content_type
Signed-off-by: Duncan Burke <duncan.burke@orionvm.com.au>
ac7e078
Duncan Burke Add support for setting any amqp or application headers
Signed-off-by: Duncan Burke <duncan.burke@orionvm.com.au>
3fd438e
Marcello Ceschia Merge branch 'master' into ssl 5f462b6
Marcello Ceschia set version to 0.4.1 15b105b
@marcelloceschia marcelloceschia update Makefile for packaging 66eb465
@ents
ents commented on ac7e078 May 26, 2015

How must be a result SQL query to set headers ?
Somthing like this doesn't work
SELECT * from amqp.publish(1, 'psql', '', 'message', '{{"delivery_mode", 2}}'::varchar[][2], null)

@keithf4
Member
keithf4 commented Mar 15, 2016

Looking for anyone that would be able to work on implementing this with the current version and bundle it as an extension update.

@marcelloceschia

I can try to merge the ssl branch with the current master. But are there any plans to integrate this into master/develop?

@marcelloceschia

updated ssl branch

Marcello Ces... added some commits Mar 16, 2016
@keithf4
Member
keithf4 commented Mar 30, 2016

I do plan on doing my best to try and get this pulled into the master branch if possible. C is not my strong suit at the moment, so may take a while.

@marcelloceschia

@keithf4 If you have any questions, feel free to contact me.
I have the latest version from ssl branch running in one productive environment that requires ssl connections.

@keithf4
Member
keithf4 commented Mar 30, 2016

So I think I'd like to see about getting the updated librabbitmq library in place before trying to get this pulled in.

#18

Seems that would be better long term to make sure the base libraries are up to date and working before pulling in a new major feature like this. I'm going to be testing out that pull request to the best of my ability to make sure all the basic stuff is working and will then push out a new version. Could use any additional assistance you can provide testing that then.

@marcelloceschia

That's a good idea. If you create a feature branch with the latest library version, I will reimplement the ssl support against this branch and you can publish a new version 0.5.0 with latest library version and ssl support

@postwait
Member

It appears that @extschema@.publish changed signature and the old one was removed? Am I reading that diff correctly? If so, this would break existing clients of the extension. Can you confirm the old function signature is left in place and "does the right thing?"

@marcelloceschia

@postwait yes @extschema@.publish signature changed. But if you read this carefully, you will see that this only extends the old signature:

old:

CREATE FUNCTION @extschema@.publish(broker_id integer, exchange varchar, routing_key varchar, message varchar, delivery_mode integer default null, content_type varchar default null, reply_to varchar default null, correlation_id varchar default null)

new:

CREATE FUNCTION @extschema@.publish(broker_id integer, exchange varchar, routing_key varchar, message varchar, delivery_mode integer default null, content_type varchar default null, reply_to varchar default null, correlation_id varchar default null, headers varchar[][2] default null, properties varchar[][2] default null)

to allow header routing as well.
But I will do this PR for a newer version of the amqp library as discussed with @keithf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment