Fix not getting correct sender email address from forwarding email by Gmail rules #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacksonh
reviewed
Aug 4, 2022
| // x-forwarded-for is a space separated list of email address | ||
| // the first one is the forwarding email sender and the last one is the recipient | ||
| // e.g. 'X-Forwarded-For: sender@omnivore.app recipient@omnivore.app | ||
| const forwardedFrom = headers['x-forwarded-for']?.toString().split(' ')[0] |
There was a problem hiding this comment.
I guess this is the key to the whole thing here.
There was a problem hiding this comment.
Yeah, I have updated the description.
To sum up, the issue is Gmail changes the from to the original sender email address instead of the Omnivore account email address.
jacksonh
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gmail will add some headers when forwarding emails by some rules:
X-Forwarded-To: recipient@omnivore.appX-Forwarded-For: sender@omnivore.app recipient@omnivore.appand the
fromandtoheaders become the original sender and recipient's email addresses.In this case, we are sending the original sender email address to Pub/Sub instead of the user's Omnivore account email address.
We fixed it by getting the Omnivore account email from the
X-Forwarded-Forheader and sending it to Pub/Sub.