Initial CI #3
Merged
Initial CI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwhswenson
requested changes
May 9, 2024
| name: CI | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
add pull_request as a trigger as well
There was a problem hiding this comment.
Do we have specific PR events we want to run on or just all PR events?
There was a problem hiding this comment.
The default is opened, reopened, and synchronize which should be enough for this and the changes have been pushed.
.github/workflows/ci.yaml
Outdated
| python -m pip install --upgrade pip setuptools wheel | ||
| python -m pip install --no-cache-dir . | ||
| python -m pip install --no-cache-dir '.[test]' | ||
| cd tests/ |
There was a problem hiding this comment.
Probably move this down to be part of the Run tests step. Also, this will break the current pytest command (since it would now be running tests in the tests/tests/ directory).
dwhswenson
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial GitHub action for use in testing this project. It will later be adapted to handle
mypyand linting down the line.