Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of blank space between sections in top-level file list #421

Closed
dgelessus opened this issue Oct 17, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@dgelessus
Copy link

commented Oct 17, 2017

The spacing between the sections in the top-level file list seems unusually big - much larger than the spacing around headers in the iOS Settings app or in Pythonista's settings for example.

This is even more visible if the favorites and/or recent external files list is empty, because those lists include a small separator at the top - and when the lists are empty, that separator merges with the large spacing below, making it even larger.

This is on iOS 10, if it makes a difference.

@omz

This comment has been minimized.

Copy link
Owner

commented Oct 18, 2017

This does indeed seem to be an issue with iOS 10, there's quite a bit less spacing on iOS 11 (as intended).

@dgelessus

This comment has been minimized.

Copy link
Author

commented Oct 18, 2017

I just noticed something interesting related to this issue. It might have something to do with the system text size setting. For comparison, here are the main file list (with the huge spacing) and the Pythonista settings (with normal spacing) with system text size at minimum (which is what I use normally):

img_0872 img_0873

And the same with system text size at maximum:

img_0874 img_0875

In the main file list, the height of spacing plus header text remains constant, no matter what the text size is. In the settings, the height of the spacing remains constant, but the total height changes when the header text height changes.

Another thing I've noticed (somewhat unrelated) is that in the file list, the cell title text changes size based on the system text size. However, in many other table views (like the Pythonista settings) it is always at the default ("medium") text size. That seems like a bug to me.

@omz

This comment has been minimized.

Copy link
Owner

commented Oct 18, 2017

Interesting. To be honest, I haven’t really looked much at the system-level font size setting yet, and I wasn’t aware that it currently affects the library view in Pythonista.

@dgelessus

This comment has been minimized.

Copy link
Author

commented Oct 19, 2017

To clarify, the font size setting is supposed to change the text size in table view cells (see how the iOS Settings app reacts for example). The bug is that the text doesn't resize in most other table views in Pythonista.

@zrzka

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2017

Not just cells, see this for example. It's called iOS Dynamic Type and it basically should change text size everywhere. I would expect it should change text size everywhere except Python code, where I can override it in Pythonista settings.

@omz

This comment has been minimized.

Copy link
Owner

commented Oct 19, 2017

Yeah, I’m aware that I should support this eventually, but I’d like to do it in a somewhat consistent manner, not just in some random part of the app. That’s quite a bit of work, as I’d have to look at pretty much every piece of UI, and it’s unlikely that I’ll get to it for this release.

@zrzka

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2017

Agree, I don't see it as something with big priority. Personally, I don't use this feature at all. But also understand how it can be useful for people with some kind of health issues / disabilities.

@omz

This comment has been minimized.

Copy link
Owner

commented Oct 19, 2017

The extraneous blank space should be fixed in the new beta (build 311014). Dynamic Text support should probably be a separate issue.

@omz omz closed this Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.