Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make comment in sitemap optional #8

Open
bnomei opened this issue Sep 7, 2018 · 3 comments
Open

make comment in sitemap optional #8

bnomei opened this issue Sep 7, 2018 · 3 comments

Comments

@bnomei
Copy link

@bnomei bnomei commented Sep 7, 2018

i get the idea that giving you credit in the sitemap seems reasonable.

<!-- Sitemap generated using https://github.com/omz13/kirby3-xmlsitemap -->

but still i would like you to remove it or make it optional because:

  • i value my clients and their customers security most. none of the code i use gives away directly what cms is used. so attackers do not know which cms was used. the new pages/media paths in thumbs might be a hint. no string reference to kirby whatsoever.
  • your plugin could in theory expose an vulnerability and i would like to hide that as much as possible.
@bnomei
Copy link
Author

@bnomei bnomei commented Sep 7, 2018

oh its in the xsl as well.

@omz13
Copy link
Owner

@omz13 omz13 commented Sep 7, 2018

An option to hide is planned.

Also, option to not do the style sheet (because that could be used as an identification vector).

@bvdputte
Copy link

@bvdputte bvdputte commented Oct 1, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.