Update mapbox sdk 7.2.0 #274

ekigamba · 2019-03-04T15:37:29Z

Fixes #19

coveralls · 2019-03-04T18:29:34Z

Pull Request Test Coverage Report for Build 1275

24 of 221 (10.86%) changed or added relevant lines in 21 files are covered.
39 unchanged lines in 19 files lost coverage.
Overall coverage increased (+0.3%) to 33.241%

Changes Missing Coverage	Changed/Added Lines	%
library/src/main/java/io/ona/kujaku/helpers/MapboxLocationComponentWrapper.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/FociBoundaryActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/PaddedBboxCalculatorActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/BoundsAwareActivity.java	3	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/BoundsChangeListenerActivity.java	3	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/CardActivity.java	3	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/ConfigurableLocationCircleActivity.java	3	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/HighLevelLocationAddPointMapView.java	3	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/HighLevelMapView.java	3	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/LowLevelLocationAddPointMapView.java	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
sample/src/main/java/io/ona/kujaku/sample/activities/FeatureClickStatusActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/WmtsActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/BoundsChangeListenerActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/HighLevelLocationAddPointMapView.java	1	0.0%
library/src/main/java/io/ona/kujaku/activities/MapActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/CustomMarkerLowLevelAddPoint.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/PaddedBboxCalculatorActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/CaseRelationshipActivity.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/LowLevelLocationAddPointMapView.java	1	0.0%
sample/src/main/java/io/ona/kujaku/sample/activities/LowLevelManualAddPointMapView.java	1	0.0%

Totals
Change from base Build 1258:	0.3%
Covered Lines:	1686
Relevant Lines:	5072

💛 - Coveralls

githengi · 2019-03-06T15:41:41Z

Update the ReadMe and other documentation

utils/src/test/java/io/ona/kujaku/helpers/converters/GeoJSONHelperTest.java

library/src/main/java/io/ona/kujaku/views/KujakuMapView.java

library/src/test/java/io/ona/kujaku/layers/ArrowLineLayerTest.java

library/src/test/java/io/ona/kujaku/layers/BoundaryLayerTest.java

library/src/main/java/io/ona/kujaku/views/KujakuMapView.java

sample/src/main/java/io/ona/kujaku/sample/activities/CaseRelationshipActivity.java

library/src/main/java/io/ona/kujaku/views/KujakuMapView.java

This fix also re-adds the geojson sources & wmts layers to the map when the style is changed and finishes loading

- This commit loads the streets-v11 layer for the sample activities since the MapView no longer has a default style. - Fixes layer and source operations performed in the sample code before the style has loaded

Fixes #240

Re-add Kujaku layers if the style changes

- Add tests for KujakuLayer.getLayerIds() - Remove Mapbox LocationComponent initialization after checking for permission locations - Remove conditional LocationComponent initialization based on location permissions

There is no default style for the MapView and therefore the host application requires to define it explicitly. This means that KujakuMapView will always receive the callback when the host application does this. This is because the host application needs to wait for the MapView to load before setting the style

onaio deleted a comment Mar 5, 2019

ekigamba force-pushed the issue/update-mapbox-sdk-7.2.0 branch from cd27ab3 to d97cb83 Compare March 6, 2019 10:55

ekigamba requested review from vincent-karuri and githengi March 6, 2019 14:18