Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement .crxignore #51
referenced this pull request
Sep 21, 2016
although I feel ignore files or selecting them in a finer way (cf. #66) would help, I don't believe supporting an ignore file is the first step to implement it.
I'd rather have a good and solid API then add an ignore file if this is a common need. I'd rather stay close to the CLI rather than having an implicit configuration file – we already have too many of them.
I hope you don't mind me closing your proposal.
In my opinion, a crxignore file is just a simpler. It provides a way to easily maintain the codebase. If a new folder is added, the workflow is quite easy. I just update all my ignore files. In the event we opt for a CLI, then either I have an extra script file which contains the command with all the ignore files appended or I have it in package.json. Updating a script and/or the package.json isn't as easy.
The crxignore also allows for nested ignores i.e. if I have a module shared across multiple extensions.
And of course, this isn't to say a API/CLI option is not need but that it should be coupled with the crxignore.
Oh interesting use case! What is the layout of your repos/code then?
To me, having a configurable exclusion/files whitelisting at the API level is more important because then it is just a matter of how you feed them (via CLI, via ignore file, via env variables etc.) so I suggest to do it in 3 moves:
Although we have to be careful because the gitignore spec works differently than the minimatch one.
@bluejamesbond because the branch diverged, would you be happy to (re)submit any of the above points as a PR?