Skip to content

Fix buildXML() call for extension w/o update_url #22

Merged
merged 1 commit into from May 15, 2013

2 participants

@alexeykuzmin
Collaborator

ChromeExtension.generateUpdateXML(); must not be called if extension has no update_url field in manifest.

@oncletom oncletom merged commit 2172d59 into oncletom:master May 15, 2013

1 check passed

Details default The Travis CI build passed
@oncletom
Owner

Thank you for the fix. I've added a test to avoid reproducing the problem :-)

@alexeykuzmin
Collaborator

Thank you for great plugin)

Would you mind to update npm package?

@oncletom
Owner

Yep it's in the pipe, just finishing publishing tests and README, it's online in a couple of minutes :-)

Edit: it's live! and I gave you commit access too.

@alexeykuzmin
Collaborator

it's live!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.