Adapt Makefile for RPM packaging #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building an RPM via rpmbuild, we need to: * pass system default compiler flags, example from ROSA 2023.1: $ rpm -E %optflags -O2 -fomit-frame-pointer -gdwarf-4 -Wstrict-aliasing=2 -pipe -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fPIC -fstack-protector-strong --param=ssp-buffer-size=4 -m64 -mtune=generic * pass system default linker flags * pass directory where files should be copied to (DESTDIR) * build an unstripped binary, RPM will strip it by itself and save debuginfo in a special way All these changes will be usefull for any other packaging format, not only RPM.
|
BSD systems may benefit from automaticaly set correct compiler |
|
This would disable optimization and stripping for the manual build/install. |
|
Agree, -O2 should be left by default. What about stripping, is it really needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building an RPM via rpmbuild, we need to:
All these changes will be usefull for any other packaging format, not only RPM.