Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use directly fugit instead of rufus-scheduler #200
Sidekiq-cron is not using rufus-scheduler itself but rather its cron logic which recently got spun off in the fugit gem (https://github.com/floraison/fugit).
This patch makes Sidekiq-cron depend directly on fugit instead of rufus-scheduler.
A refinement would be to cache the parsed cron line in the Sidekiq-cron Job instance so that there is no need to reparse each time.
Here is the
Thanks for opening this up, @jmettraux. We were also recently surprised by the sudden loss of compatibility and would love to see sidekiq-cron move back to stability.
The core of your change that swaps rufus-scheduler logic with fugit feels muddied by some changes you've included that are unrelated. Would you mind pulling those changes back? I respect that you feel strongly about your chosen styles, but I imagine it's just as like @ondrejbartas feels the same as theirs. Seeing as we are in their space, it seems respectful to keep our changes constrained to the topics at hand.
Good morning Nathan,
OK, I contribute mud.
"sudden loss of compatibility"... Please read http://jmettraux.skepti.ch/20180601.html?t=Gemfile_lock&f=200
That leaves just
I trust @ondrejbartas will do the right thing when he has time. I don't care if he rejects my PR, it's rather a message from me to him, showing how to go from rufus-scheduler to fugit. I have interacted with him before and I must say he's a nice chap. I'm sure he'll do what he, as project owner, feels is right and I will respect his choices.
I didn't see that line about using Jeweler. Thanks for pointing that out to me.
I believe I misspoke with the my use of the word "sudden," and for that I apologize. In hindsight, a better word would have been "unexpected," or perhaps no descriptor at all. We check in our Gemfile.lock, as you are absolutely correct in advising others do, and this never caused us a moment of downtime.
Thanks for your contributions and taking the time to courteously address someone looking to help this gem move back toward stability for the community.
The test failures are a result of a weird issue I think, namely that tests fail when run after 11pm because of
If hour is
What's interesting though is that (when run on travis) one of the performance tests fails in all ruby versions. Is it possible that the update to