From b2e0326557d310bb19d36f7866fd4cf15e80c558 Mon Sep 17 00:00:00 2001
From: Russell McGuire <russell.w.mcguire@intel.com>
Date: Tue, 21 Apr 2026 17:21:36 -0700
Subject: [PATCH] Update to 1.28.4

Add notes for test content

Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
---
 CHANGELOG.md     |  5 +++++
 CMakeLists.txt   | 17 ++++++++++++++---
 PRODUCT_GUID.txt |  4 ++--
 3 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index d6cb06fc..4f41ceff 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,9 @@
 # Level zero loader changelog
+## v1.28.4
+* Add README.md and CONTRIBUTING.md changes for Unit Testing
+* Add CMakefile.txt check for PRODUCT_GUID.txt updates before release
+* Update to version 1.28.4
+* Fix bug in 1.28.3 that didn't update the PRODUCT_GUID.txt
 ## v1.28.3
 * Address clang build warnings for empty structures
 * Fix successive calls to zeInitDivers when no drivers found failing
diff --git a/CMakeLists.txt b/CMakeLists.txt
index a7cf2c3a..32022a8b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -13,7 +13,7 @@ if(MSVC AND (MSVC_VERSION LESS 1900))
 endif()
 
 # This project follows semantic versioning (https://semver.org/)
-project(level-zero VERSION 1.28.3)
+project(level-zero VERSION 1.28.4)
 include(GNUInstallDirs)
 
 find_package(Git)
@@ -284,9 +284,14 @@ if(EXISTS "${PRODUCT_GUID_FILE}")
         )
         file(WRITE "${PRODUCT_GUID_FILE}" "${PROJECT_VERSION}\n${GENERATED_PRODUCT_GUID}")
         message(STATUS "Generated Product GUID: ${GENERATED_PRODUCT_GUID} for version ${PROJECT_VERSION}")
+        message(FATAL_ERROR
+            "PRODUCT_GUID.txt has been regenerated for version ${PROJECT_VERSION}.\n"
+            "Please commit the updated PRODUCT_GUID.txt before continuing:\n"
+            "  git add ${PRODUCT_GUID_FILE}\n"
+            "  git commit -m 'Update PRODUCT_GUID.txt for version ${PROJECT_VERSION}'\n"
+            "Then re-run cmake.")
         else()
-        string(REPLACE "\n" ";" GUID_CONTENTS "${SAVED_PRODUCT_GUID}")
-        list(GET GUID_CONTENTS 1 GENERATED_PRODUCT_GUID)
+        list(GET SAVED_PRODUCT_GUID 1 GENERATED_PRODUCT_GUID)
     endif()
 else()
     execute_process(
@@ -295,6 +300,12 @@ else()
         OUTPUT_STRIP_TRAILING_WHITESPACE
     )
     file(WRITE "${PRODUCT_GUID_FILE}" "${PROJECT_VERSION}\n${GENERATED_PRODUCT_GUID}")
+    message(FATAL_ERROR
+        "PRODUCT_GUID.txt did not exist and has been created for version ${PROJECT_VERSION}.\n"
+        "Please commit it before continuing:\n"
+        "  git add ${PRODUCT_GUID_FILE}\n"
+        "  git commit -m 'Add PRODUCT_GUID.txt for version ${PROJECT_VERSION}'\n"
+        "Then re-run cmake.")
 endif()
 message(STATUS "Using Product GUID: ${GENERATED_PRODUCT_GUID} for version ${PROJECT_VERSION}")
 
diff --git a/PRODUCT_GUID.txt b/PRODUCT_GUID.txt
index 12701109..b0b273ea 100644
--- a/PRODUCT_GUID.txt
+++ b/PRODUCT_GUID.txt
@@ -1,2 +1,2 @@
-1.28.2
-115378b3-db3b-44cf-8c29-eb1184210c18
\ No newline at end of file
+1.28.4
+cfa0eed1-ba15-4a52-8efe-5d532373fded
\ No newline at end of file