Skip to content
This repository

DevKit dk.rb install path is too generic #80

Closed
jonforums opened this Issue August 04, 2011 · 7 comments

2 participants

Jon Luis Lavena
Jon
Owner

While upgrading a development Ruby build, I get

C:\DevKit>ruby dk.rb install
[INFO] Updating convenience notice gem override for 'C:/ruby19'
[INFO] Installing 'C:/ruby19/lib/ruby/gems/1.9.1/gems/yard-0.7.1/lib/yard/rubygems/defaults/operating_system.rb'
[INFO] Installing 'C:/ruby19/lib/ruby/gems/1.9.1/gems/yard-0.7.2/lib/yard/rubygems/defaults/operating_system.rb'
[INFO] Installing 'C:/ruby19/lib/ruby/site_ruby/devkit.rb'

likely due to

https://github.com/oneclick/rubyinstaller/blob/master/resources/devkit/dk.rb.erb#L229

Investigate.

Jon
Owner

I've got to make time to confirm, but I'm likely to change to

core_rubygems = Dir.glob("#{path}/lib/ruby/[1-9].*/rubygems")

as it's faster than alternatives that cause an intermediate array of strings to be created. Speak up now if you see any gotchas with this.

Jon
Owner

should have changed to this a long time ago. ruby dk.rb install now screams rather than poking along like it used to do.

Jon jonforums closed this in 2c6ce79 August 06, 2011
Luis Lavena
Owner

@jonforums bumping this up.

Any plans for another DevKit release?

Jon
Owner
  • need to verify tdm-32-4.6.1 should be the new default DevKit by building 1.8.7, 1.9.3, and trunk on Win7
  • need to confirm no issues when building/running on XP
  • should get Wayne to test with RailsInstaller

For my personal builds, I use tdm-32-4.6.1 on Win7 32bit for 1.9.3 and trunk with no apparent issues. All TCS builds still using current tdm-32-4.5.2 until I get time to test on XP.

What are your results and thoughts?

Luis Lavena
Owner

Please test EventMachine and see if their C++ code gets linked without dependencies on stdc++ libs.

I haven't tested tdm-32-4.6.1 as I was working with mingw-w64 builds instead, but the changes to threading model and dependency on winpthreads might be a problem.

Jon
Owner

re: mingw-w64 builds I have issues with mingw64-32-4.6.3 but haven't investigated.

What did you use to build the latest 1.8.7 security release?

Short-term, it's best to keep tdm-32-4.5.2 as default and release an updated DevKit (4.5.2) that includes this dk.rb enhancement. Agree?

Luis Lavena
Owner

What did you use to build the latest 1.8.7 security release?

tdm-32-4.5.2

Short-term, it's best to keep tdm-32-4.5.2 as default and release an updated DevKit (4.5.2) that includes this dk.rb enhancement. Agree?

Agree :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.