Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation without default features, and add CI job to check it #37

Merged
merged 3 commits into from Nov 12, 2019

Conversation

@luizirber
Copy link
Contributor

luizirber commented Nov 6, 2019

Hi!

I was trying out adding needletail to a project and using the wasm32-unknown-unknown target, but for that I had to disable the compression feature (which is also default). I ended up finding an error, and seems like CI wasn't checking for this case, so I also added another job.

Oh: is it OK to add another CI job, for checking compilation for wasm32-unknown-unknown target? It is enough to just run cargo build --target wasm32-unknown-unknown (and add the target with rustup), but I think it gets messier to add to an existing job than to create a new one.

UPDATE: the wasm32 CI job is now in 07743c8, but I can remove it from the PR if that's not desirable.

@luizirber luizirber force-pushed the luizirber:li_no_default_features branch from 5b590fc to 65221f1 Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #37   +/-   ##
====================================
  Coverage      90%   90%           
====================================
  Files           5     5           
  Lines         590   590           
====================================
  Hits          531   531           
  Misses         59    59
Impacted Files Coverage Δ
src/formats/mod.rs 86.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a427677...07743c8. Read the comment docs.

@luizirber luizirber force-pushed the luizirber:li_no_default_features branch from 9930fd7 to 07743c8 Nov 6, 2019
@luizirber

This comment has been minimized.

Copy link
Contributor Author

luizirber commented Nov 8, 2019

Ready for review @bovee

@bovee

This comment has been minimized.

Copy link
Contributor

bovee commented Nov 12, 2019

This is fantastic; super exciting it's this easy to get it run on wasm. Thanks for adding tests on the not(feature = "compression") branches too!

@bovee bovee merged commit 6ed22cd into onecodex:master Nov 12, 2019
9 checks passed
9 checks passed
ci-checks Workflow: ci-checks
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-on-wasm-target Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-without-default-features Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a427677...07743c8
Details
codecov/project 90% remains the same compared to a427677
Details
@luizirber luizirber deleted the luizirber:li_no_default_features branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.