Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to bypass validation tasks if node IPv4 addresses are public #933

Closed
samip5 opened this issue Sep 11, 2023 · 3 comments · Fixed by #938
Closed

Ability to bypass validation tasks if node IPv4 addresses are public #933

samip5 opened this issue Sep 11, 2023 · 3 comments · Fixed by #938

Comments

@samip5
Copy link
Contributor

samip5 commented Sep 11, 2023

The validation should take into account if a user specifies public addresses instead for nodes as they might be in a private LAN, but only accessible via public IP (or bastion host) for SSH

@onedr0p
Copy link
Owner

onedr0p commented Sep 11, 2023

Not a bad idea, I guess you can bypass it if the IPs aren't RFC1918 and whatever the IPv6 equivalent is?

@samip5
Copy link
Contributor Author

samip5 commented Sep 11, 2023

Hmm, I'm thinking if it should just be a new field under nodes? Like internal IP and external? Internal should always be specified but external not?

@onedr0p
Copy link
Owner

onedr0p commented Sep 11, 2023

Ah that makes more sense, sorry I misread your original ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants