Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Onejs will include itself from submodule node_modules even when passing --exclude one #8

mixu opened this Issue May 31, 2012 · 3 comments


None yet
2 participants

mixu commented May 31, 2012

For example:

chat_foo/package.json "dependencies" has "chat": "1.0.0"
chat/package.json "dependencies" has "one": ">1.5"

When running:

onejs --exclude one build chat_foo/package.json

onejs will still try to load onejs from chat_foo/node_modules/chat/node_modules/one/ which will cause the following error

[2012-05-31 15:26:48.972] [ERROR] onejs - Failed to render template "module"
[2012-05-31 15:26:48.972] [ERROR] onejs - { message: 'unknown_partial 'path'' }

if(error) throw error;
This can be worked around by moving "one" to "devDependencies" in "chat" but I would assume that --exclude one should work in this case?


azer commented Jun 5, 2012

I confirmed that BLACK_LIST and --exclude doesn't work for nested node_modules directories. I'm working on this issue right now.


azer commented Jun 11, 2012

fixed by recent commits.

@azer azer closed this Jun 11, 2012


mixu commented Jun 11, 2012


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment