Add RAR handler #33
Merged
Add RAR handler #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
reviewed
Nov 24, 2021
kissgyorgy
force-pushed
the
add_rar
branch
2 times, most recently
from
70b89ae
to
c66bbbd
Compare
It is using an external library to handle v4 and v5 format too. It is using the unar external tool to extract found RAR files: https://theunarchiver.com/command-line The unar command will create empty files for password protected rar files and empty directory without any files when it's encrypted. These are reflected in the test cases.
The unar tool will extract no files when given an encrypted file, but unlob will create an empty directory. Git cannot track empty directories, so we need to have something there, but on test assert, we need to ignore this file.
vlaci
approved these changes
Nov 26, 2021
qkaiser
reviewed
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handler and tests for RAR.
The handler will find two distinct RAR magics: from v1.5 to v4 (called $magic_v4), and v5 (called $magic_v5).
There's only a test for RAR v5 at the moment.