New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed code to use specific XPathFactoryImpl #192

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@dswitzer
Contributor

dswitzer commented Oct 3, 2018

This changes the XPathFactory call to use a specific XPathFactoryImpl to avoid issues where an environment may be using a default implementation that's incompatible with the code (such as using an outdated Saxon parser). This change attempts to use the default Java implementation, but if that is unavailable will fallback to try to load the default.

This will also help to ensure the XML is always parsed in a consistent manor, since everyone should be using the same XPathFactoryImpl.

This should resolve Issue #191.

Changed code to use specific XPathFactoryImpl
This changes the XPathFactory call to use a specific XPathFactoryImpl to avoid issues where an environment may be using a default implementation that's incompatible with the code (such as using an outdated Saxon parser). This change attempts to use the default Java implementation, but if that is unavailable will fallback to try to load the default.

This will also help to ensure the XML is always parsed in a consistent manor, since everyone should be using the same XPathFactoryImpl.
@coveralls

This comment has been minimized.

coveralls commented Oct 3, 2018

Coverage Status

Coverage decreased (-0.1%) to 94.841% when pulling 2311853 on dswitzer:patch-1 into 54b2936 on onelogin:master.

@pitbulk pitbulk merged commit 8aed940 into onelogin:master Oct 23, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.1%) to 94.841%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment