New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX getSelfHost no longer returns a port number #154

Merged
merged 1 commit into from Sep 8, 2016

Conversation

Projects
None yet
2 participants
@dhensby
Contributor

dhensby commented Sep 6, 2016

Fixes #153

  • Make sure getSelfHost doesn't return a port
  • Added getSelfPort to normalise port fetching
Show outdated Hide outdated lib/Saml2/Utils.php
@dhensby

This comment has been minimized.

Show comment
Hide comment
@dhensby

dhensby Sep 8, 2016

Contributor

@pitbulk I've made this change based on your feedback. Is it ok to go in or so you have some concerns?

Contributor

dhensby commented Sep 8, 2016

@pitbulk I've made this change based on your feedback. Is it ok to go in or so you have some concerns?

@pitbulk pitbulk merged commit 48f98cf into onelogin:master Sep 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dhensby dhensby deleted the dhensby:pulls/self-host-without-port branch Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment