New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Use correct host on response destination fallback check #156

Merged
merged 1 commit into from Sep 7, 2016

Conversation

Projects
None yet
2 participants
@dhensby
Contributor

dhensby commented Sep 6, 2016

Fixes #151

I'm not sure how I can test this in the current test suite - any advice?

Show outdated Hide outdated lib/Saml2/Response.php
@pitbulk

This comment has been minimized.

Show comment
Hide comment
@pitbulk

pitbulk Sep 7, 2016

Contributor

I plan to add some improvements on the toolkit in the next weeks, so I will take care of the test of that part.

Contributor

pitbulk commented Sep 7, 2016

I plan to add some improvements on the toolkit in the next weeks, so I will take care of the test of that part.

@pitbulk pitbulk merged commit 7a87f05 into onelogin:master Sep 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dhensby dhensby deleted the dhensby:pulls/proper-destination-check branch Sep 7, 2016

@dhensby

This comment has been minimized.

Show comment
Hide comment
@dhensby

dhensby Sep 7, 2016

Contributor

Thanks

Contributor

dhensby commented Sep 7, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment