New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strpos bug when decrypting assertions #183

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
2 participants
@samstoller

samstoller commented Jan 24, 2017

Issue introduced in 994cacb

strpos returns 1st occurence of characters in a string, in this case 0, which evaluates to false so the correct namespace is not applied. This causes assertion signatures to fail with the error 'Reference validation failed'.

@pitbulk pitbulk merged commit 2963ee4 into onelogin:master Jan 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pitbulk

This comment has been minimized.

Show comment
Hide comment
@pitbulk

pitbulk Jan 24, 2017

Contributor

Thanks for catch the typo ;)

Contributor

pitbulk commented Jan 24, 2017

Thanks for catch the typo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment