Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make tests pass in 2020 #156

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@bmwiedemann
Copy link
Contributor

commented Aug 14, 2019

Make tests pass in 2020

For this we update expiry of 2020 to 2999

diff decoded is

a/tests/data/responses/unsigned_response.xml
b/tests/data/responses/unsigned_response.xml
@@ -9,15 +9,15 @@
     <saml:Subject>
       <saml:NameID SPNameQualifier="hello.com" Format="urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress">someone@example.com</saml:NameID>
       <saml:SubjectConfirmation Method="urn:oasis:names:tc:SAML:2.0:cm:bearer">
-        <saml:SubjectConfirmationData NotOnOrAfter="2020-06-17T14:59:14Z" Recipient="http://stuff.com/endpoints/endpoints/acs.php" InResponseTo="_57bcbf70-7b1f-012e-c821-782bcb13bb38"/>
+        <saml:SubjectConfirmationData NotOnOrAfter="2999-06-17T14:59:14Z" Recipient="http://stuff.com/endpoints/endpoints/acs.php" InResponseTo="_57bcbf70-7b1f-012e-c821-782bcb13bb38"/>
       </saml:SubjectConfirmation>
     </saml:Subject>
-    <saml:Conditions NotBefore="2010-06-17T14:53:44Z" NotOnOrAfter="2021-06-17T14:59:14Z">
+    <saml:Conditions NotBefore="2010-06-17T14:53:44Z" NotOnOrAfter="2999-06-17T14:59:14Z">
       <saml:AudienceRestriction>
         <saml:Audience>http://stuff.com/endpoints/metadata.php</saml:Audience>
       </saml:AudienceRestriction>
     </saml:Conditions>
-    <saml:AuthnStatement AuthnInstant="2011-06-17T14:54:07Z" SessionNotOnOrAfter="2021-06-17T22:54:14Z" SessionIndex="_51be37965feb5579d803141076936dc2e9d1d98ebf">
+    <saml:AuthnStatement AuthnInstant="2011-06-17T14:54:07Z" SessionNotOnOrAfter="2999-06-17T22:54:14Z" SessionIndex="_51be37965feb5579d803141076936dc2e9d1d98ebf">
       <saml:AuthnContext>
         <saml:AuthnContextClassRef>urn:oasis:names:tc:SAML:2.0:ac:classes:Password</saml:AuthnContextClassRef>
       </saml:AuthnContext>
tests: make tests pass in 2020
For this we update 2020 to 2999

diff decoded is
a/tests/data/responses/unsigned_response.xml
b/tests/data/responses/unsigned_response.xml
@@ -9,15 +9,15 @@
     <saml:Subject>
       <saml:NameID SPNameQualifier="hello.com" Format="urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress">someone@example.com</saml:NameID>
       <saml:SubjectConfirmation Method="urn:oasis:names:tc:SAML:2.0:cm:bearer">
-        <saml:SubjectConfirmationData NotOnOrAfter="2020-06-17T14:59:14Z" Recipient="http://stuff.com/endpoints/endpoints/acs.php" InResponseTo="_57bcbf70-7b1f-012e-c821-782bcb13bb38"/>
+        <saml:SubjectConfirmationData NotOnOrAfter="2999-06-17T14:59:14Z" Recipient="http://stuff.com/endpoints/endpoints/acs.php" InResponseTo="_57bcbf70-7b1f-012e-c821-782bcb13bb38"/>
       </saml:SubjectConfirmation>
     </saml:Subject>
-    <saml:Conditions NotBefore="2010-06-17T14:53:44Z" NotOnOrAfter="2021-06-17T14:59:14Z">
+    <saml:Conditions NotBefore="2010-06-17T14:53:44Z" NotOnOrAfter="2999-06-17T14:59:14Z">
       <saml:AudienceRestriction>
         <saml:Audience>http://stuff.com/endpoints/metadata.php</saml:Audience>
       </saml:AudienceRestriction>
     </saml:Conditions>
-    <saml:AuthnStatement AuthnInstant="2011-06-17T14:54:07Z" SessionNotOnOrAfter="2021-06-17T22:54:14Z" SessionIndex="_51be37965feb5579d803141076936dc2e9d1d98ebf">
+    <saml:AuthnStatement AuthnInstant="2011-06-17T14:54:07Z" SessionNotOnOrAfter="2999-06-17T22:54:14Z" SessionIndex="_51be37965feb5579d803141076936dc2e9d1d98ebf">
       <saml:AuthnContext>
         <saml:AuthnContextClassRef>urn:oasis:names:tc:SAML:2.0:ac:classes:Password</saml:AuthnContextClassRef>
       </saml:AuthnContext>
@coveralls

This comment has been minimized.

Copy link

commented Aug 14, 2019

Coverage Status

Coverage remained the same at 95.83% when pulling 86645a8 on bmwiedemann:FTBFS2020 into 32f4d24 on onelogin:master.

@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

btw: travis python-3.4 error is bogus: This lxml version requires Python 2.7, 3.5 or later.

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:FTBFS2020 branch from 901e8f1 to d5a662f Aug 21, 2019

Drop broken python-3.4 tests
They failed with `This lxml version requires Python 2.7, 3.5 or later.`

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:FTBFS2020 branch from d5a662f to 86645a8 Aug 21, 2019

@pitbulk pitbulk merged commit 914c696 into onelogin:master Sep 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.83%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.