Impl std::error::Error + Send + 'static for errors::Error. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like `Error::source` replaces `Error::cause`. Originally I added them both since I wasn't sure it made sense to only include one or the other, but since our lowest supported rust version is 1.32, and `source` was added in 1.30, and `cause` was deprecated as of 1.33, anyone using this crate will for sure be able to work with `source`.
onelson
force-pushed
the
error-chain-support
branch
from
749537b
to
53ac488
Compare
onelson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just adding implementations for
Error + Send + 'staticfor the crate'sErrorenum. Also includes a couple of small integration tests to ensure we maintain compat with error-chain in the releases to come.Fixes #21.