New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multiple storage components #920

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@dschelchkov
Contributor

dschelchkov commented Jul 14, 2017

No description provided.

@sleepyorion

@dschelchkov : should there be a default value for based_on_storage attribute? I see that is being referenced later as 'key' , but since it's not a required or has a default value will that resulted in the key not to existed? Unless that's the desirable behavior?

@dschelchkov

This comment has been minimized.

Show comment
Hide comment
@dschelchkov

dschelchkov Jul 17, 2017

Contributor

That's by design. Basically I need a user's input (or the pack's owner can set it at the pack level) for that attribute. If the value for that attribute is not provided (which is what's gonna happen now for all the existing packs), then the 1st branch of the matching algorithm will not be used. The 3 "branches" are as follows:

  1. if "Based On Storage" is not empty - use its value to find matching storage component
  2. if #1 didn't yield a match - compare the name of the volume components to all storage component names, in this manner: 'volume-foo' matches 'storage-foo', but "volume-foo" won't match "storage-foobar" or "barstorage-foo" etc
  3. if neither #1 or #2 worked, use the old approach of using the first storage from the array of available storage components
Contributor

dschelchkov commented Jul 17, 2017

That's by design. Basically I need a user's input (or the pack's owner can set it at the pack level) for that attribute. If the value for that attribute is not provided (which is what's gonna happen now for all the existing packs), then the 1st branch of the matching algorithm will not be used. The 3 "branches" are as follows:

  1. if "Based On Storage" is not empty - use its value to find matching storage component
  2. if #1 didn't yield a match - compare the name of the volume components to all storage component names, in this manner: 'volume-foo' matches 'storage-foo', but "volume-foo" won't match "storage-foobar" or "barstorage-foo" etc
  3. if neither #1 or #2 worked, use the old approach of using the first storage from the array of available storage components

@sleepyorion sleepyorion merged commit e0748ab into master Jul 17, 2017

@dschelchkov dschelchkov deleted the volume-windows branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment