New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard release by platform creates and discards actual release #18

Merged
merged 11 commits into from Jul 3, 2017

Conversation

Projects
None yet
2 participants
@okornev
Contributor

okornev commented Jun 30, 2017

to be consistent with commit ipmlementation

@lkhusid

lkhusid requested changes Jun 30, 2017 edited

Oleg, this is good and would work. But we can have a more optimized approach with "reverse" logic of discarding current release and moving "left-over" RFCs to a new open one. The main advantages:

  1. It will be less db i/o in most typical use-cases.
  2. The new open release will have the highest ID (in current implementation we will end up with cancelled release with ID higher than ID of current open release - which is a bit "awkward").
  3. You can optimize code by just iterating though all current release RFCs and compare their nsPath to the one of the given platform and move RFCs out to new release only if they do not match.

Finally, there is another caveat to address regardless of the discussion above. ComposedOf relation from assembly to platform does not live in the name space of the platform (due to legacy issues unfortunately). So you need to handle it specially - the most generic way would be to look-up RFC relations pointing to platform CI to see if they need to be in discarded release. (BTW, check if this is already handled or an issue for release commit scenario).

@lkhusid

This comment has been minimized.

Show comment
Hide comment
@lkhusid

lkhusid Jul 3, 2017

Contributor

Looks great. Plus it is great you "record" the right user in the discarded release.

Contributor

lkhusid commented Jul 3, 2017

Looks great. Plus it is great you "record" the right user in the discarded release.

@lkhusid lkhusid merged commit 3d52634 into oneops:master Jul 3, 2017

lkhusid pushed a commit that referenced this pull request Nov 2, 2017

lkhusid added a commit that referenced this pull request Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment