Join GitHub today
Discard release by platform creates and discards actual release #18
Oleg, this is good and would work. But we can have a more optimized approach with "reverse" logic of discarding current release and moving "left-over" RFCs to a new open one. The main advantages:
- It will be less db i/o in most typical use-cases.
- The new open release will have the highest ID (in current implementation we will end up with cancelled release with ID higher than ID of current open release - which is a bit "awkward").
- You can optimize code by just iterating though all current release RFCs and compare their nsPath to the one of the given platform and move RFCs out to new release only if they do not match.
Finally, there is another caveat to address regardless of the discussion above. ComposedOf relation from assembly to platform does not live in the name space of the platform (due to legacy issues unfortunately). So you need to handle it specially - the most generic way would be to look-up RFC relations pointing to platform CI to see if they need to be in discarded release. (BTW, check if this is already handled or an issue for release commit scenario).