New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update encoding #12

Merged
merged 5 commits into from Jun 19, 2017

Conversation

Projects
None yet
3 participants
@sugarshin
Copy link
Member

sugarshin commented May 23, 2017

  • Add encoding options for custom entity renderer
    • for mention plugin
  • Fixed draft-js version to 0.10.0
    • because draft-js-plugins-editor not working on draft-js latest version (0.10.1)
  • Upgrade dependencies
    • Summary
      • webpack to v2
      • autoprefixer to v7
      • postcss-loader to v2
  • Use Yarn

sugarshin added some commits May 23, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 23, 2017

Coverage Status

Coverage decreased (-1.0%) to 99.031% when pulling 3df6731 on update-encoding into 58ad9c9 on master.

sugarshin added some commits May 24, 2017

@sugarshin sugarshin force-pushed the update-encoding branch from 416734e to 73a1a51 May 24, 2017

@sugarshin sugarshin force-pushed the update-encoding branch from 5513918 to 09339c4 May 24, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 24, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 09339c4 on update-encoding into 58ad9c9 on master.

@sugarshin

This comment has been minimized.

Copy link
Member

sugarshin commented May 24, 2017

Could you please review this PR 🙏 @oneteam-dev/reviewers

@sugarshin sugarshin changed the title WIP: Update encoding Update encoding May 24, 2017

@@ -46,77 +46,76 @@
},
"homepage": "https://github.com/oneteam-dev/draft-js-oneteam-rte-plugin#readme",
"peerDependencies": {
"draft-js-plugins-editor": "2.0.0-beta10",
"draft-js-plugins-editor": "~2.0.0-beta.9 || 2.0.0-beta11 || 2.0.0-beta10 || 2.0.0-beta9",

This comment has been minimized.

@nantekkotai

nantekkotai May 24, 2017

この書き方が必要なのは、いつのまにか名前が変わっていることがある、とかそんな理由でしょうか?

This comment has been minimized.

@nantekkotai

nantekkotai May 24, 2017

あ、peerDependencies ですね。ちゃんと読んでなかった。

This comment has been minimized.

@sugarshin

sugarshin May 24, 2017

Member

Semver 的に正しいのは 2.0.0-beta.9 みたいな beta と数字の間にピリオドが入るかたちで、それだと ~2.0.0-beta.9 みたいなバージョンのレンジ指定が可能なのですが、そうなってない場合こうしていちいちバージョン指定してあげないと unmet peer dependency になってしまうのですよねー

This comment has been minimized.

@nantekkotai

nantekkotai May 24, 2017

お恥ずかしながら Semver という言葉を知らなかった・・・ 😮
なかなか厄介ですね。

This comment has been minimized.

@sugarshin

sugarshin May 24, 2017

Member

draft-js-plugins-editor がなかなかドラスティックでたのしいです 😂

@nantekkotai
Copy link

nantekkotai left a comment

👀 自分が理解しきれていないという不安もありますが、テストを見た感じ、問題ないように見えました 👍

@sugarshin

This comment has been minimized.

Copy link
Member

sugarshin commented May 24, 2017

ありがとうございました 🙇

@sugarshin sugarshin merged commit 233db53 into master Jun 19, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@sugarshin sugarshin deleted the update-encoding branch Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment