Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clearCache, cleanExpiredCache function #1494

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add clearCache, cleanExpiredCache function #1494

merged 2 commits into from
Aug 7, 2020

Conversation

Woollim
Copy link
Contributor

@Woollim Woollim commented Aug 6, 2020

Hi~ 👋 I'm glad to contribute toward Kingfisher

  1. Add clearCache, clenExpiredCache function
    clearCache -> Erase the cache data in memory and disk
    cleanExpiredCache -> Erase the expired cache data in memory and disk

The inspiration for this idea came from SDWebImage

SDImageCache.shared.clearCache(.all)
  1. Modify incorrect comment of cleanExpiredMemoryCache
    cleanExpiredMemoryCache works synchronously, but comment says asynchronous

@onevcat
Copy link
Owner

onevcat commented Aug 7, 2020

LGTM! Thanks.

@onevcat onevcat merged commit 9593fcf into onevcat:master Aug 7, 2020
skoduricg pushed a commit to rentpath/Kingfisher that referenced this pull request Sep 24, 2021
@onevcat
Merge pull request onevcat#1494 from Woollim/master
dc09560 
Add `clearCache`, `cleanExpiredCache` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Woollim @onevcat