Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [sdk] Allow for integer string acct.keyId in authorization function #1191

Merged
merged 9 commits into from May 27, 2022

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented May 17, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: fc07d54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink force-pushed the jribbink/allow-string-keyid branch 6 times, most recently from 3cb82c7 to 505ff6a Compare May 17, 2022 09:19
@jribbink jribbink force-pushed the jribbink/allow-string-keyid branch from 505ff6a to 0b224a5 Compare May 17, 2022 21:05
@jribbink jribbink marked this pull request as ready for review May 17, 2022 21:06
@jribbink jribbink force-pushed the jribbink/allow-string-keyid branch from 0b224a5 to 22bcf3d Compare May 17, 2022 21:07
packages/sdk/src/interaction/interaction.js Outdated Show resolved Hide resolved
packages/sdk/src/interaction/interaction.js Show resolved Hide resolved
packages/sdk/src/interaction/interaction.js Outdated Show resolved Hide resolved
packages/sdk/src/interaction/interaction.js Outdated Show resolved Hide resolved
@justinbarry justinbarry dismissed JeffreyDoyle’s stale review May 25, 2022 20:01

Feedback was addressed.

Copy link
Contributor

@justinbarry justinbarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few notes.

packages/sdk/src/interaction/interaction.js Outdated Show resolved Hide resolved
packages/sdk/src/interaction/interaction.js Outdated Show resolved Hide resolved
packages/sdk/src/interaction/interaction.js Outdated Show resolved Hide resolved
jribbink and others added 3 commits May 25, 2022 16:17
@jribbink jribbink requested a review from justinbarry May 25, 2022 23:26
@jribbink jribbink force-pushed the jribbink/allow-string-keyid branch from a3155ff to cd2141b Compare May 26, 2022 18:17
Copy link
Member

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@jribbink jribbink merged commit 90d5163 into master May 27, 2022
@jribbink jribbink deleted the jribbink/allow-string-keyid branch May 27, 2022 23:50
@github-actions github-actions bot mentioned this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authorization function auto casts keyId to a number for both account and compSig
4 participants