Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Status #576

Closed
Kay-Zee opened this issue Jul 20, 2022 · 6 comments · Fixed by #946
Closed

Block Status #576

Kay-Zee opened this issue Jul 20, 2022 · 6 comments · Fixed by #946
Assignees
Labels
Feature A new user feature or a new package API Feedback

Comments

@Kay-Zee
Copy link
Member

Kay-Zee commented Jul 20, 2022

Issue To Be Solved

Currently, when calling flow blocks get, we see the block, but nothing about it's status (i.e. finalized, executed, or sealed). It would be nice to see the status of the block

(Optional): Suggest A Solution

We will likely have to implement something on the Access API side as well, unless we want to do multiple calls for this one command.

@Kay-Zee Kay-Zee added Feature A new user feature or a new package API Feedback labels Jul 20, 2022
@sideninja
Copy link
Member

I agree. How urgent is this? Should we just do another call or wait for AN?

@simonhf
Copy link

simonhf commented Jul 20, 2022

Following :-)

@simonhf
Copy link

simonhf commented Jul 20, 2022

FYI I have been using a wrapper around flow-cli to calculate the output TPS of e.g. localnet. This seems to work okay at lower input TPS levels (e.g. < 260 TPS) because the finalized and executed block states are similar. But with higher input TPS then currently flow-cli effectively 'only' shows the block finalization rate which can be much faster than the block executed rate. For example, at input TPS 600 on localnet then flow-cli can currently be used to report a block finalization average output TPS of ~ 600 TPS, but in reality the block executed average output TPS is only ~ 260 TPS (known by inspecting the node logs). I would love to see this feature implemented to have another and more efficient way to gauge the block executed average output TPS without necessarily having to go to the trouble of examining the node logs :-)

@sideninja sideninja added the L2 label Jul 26, 2022
@Kay-Zee
Copy link
Member Author

Kay-Zee commented Aug 26, 2022

Also, an addition here, is being able to specify if you want Sealed blocks only

@chasefleming
Copy link
Member

@bluesign I saw the PR on Go SDK for the related issue. Were you planning on doing this issue as well and I should hold off on working on this?

@bluesign
Copy link
Collaborator

@chasefleming you can take this if you want, I have something else on my plate already. ( sorry I didn't see you assigned this to yourself already )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API Feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants