Fix import detection#256
Merged
Merged
Conversation
devbugging
requested review from
Kay-Zee,
janezpodhostnik,
psiemens and
turbolent
as code owners
This was referenced May 17, 2021
Merged
janezpodhostnik
approved these changes
May 20, 2021
Contributor
|
Would it be possible to write a test covering this? |
turbolent
approved these changes
May 20, 2021
Contributor
Author
Great idea, totally forgot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252
Description
Import detection was fixed so it only detects file imports.