From 1b6e4fc11ab548ab60d591a4eee523928e5e68cd Mon Sep 17 00:00:00 2001 From: Jan Bernatik Date: Wed, 15 Oct 2025 15:17:01 -0700 Subject: [PATCH] [Scheduled Txs] Remove redundant metric and increase number of histogram buckets --- module/metrics/execution.go | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/module/metrics/execution.go b/module/metrics/execution.go index 0176e6010ec..da82624f930 100644 --- a/module/metrics/execution.go +++ b/module/metrics/execution.go @@ -99,7 +99,6 @@ type ExecutionCollector struct { evmBlockTxCount prometheus.Histogram evmBlockGasUsed prometheus.Histogram callbacksExecutedCount prometheus.Histogram - callbacksExecutedTotal prometheus.Counter callbacksProcessComputationUsed prometheus.Histogram callbacksExecuteComputationLimits prometheus.Histogram } @@ -803,14 +802,7 @@ func NewExecutionCollector(tracer module.Tracer) *ExecutionCollector { Subsystem: subsystemRuntime, Name: "callbacks_executed_count", Help: "the number of callbacks executed", - Buckets: prometheus.ExponentialBuckets(1, 2, 8), - }), - - callbacksExecutedTotal: promauto.NewCounter(prometheus.CounterOpts{ - Namespace: namespaceExecution, - Subsystem: subsystemRuntime, - Name: "callbacks_executed_total", - Help: "the total number of callbacks executed", + Buckets: prometheus.ExponentialBuckets(1, 2, 9), }), callbacksProcessComputationUsed: promauto.NewHistogram(prometheus.HistogramOpts{ @@ -921,7 +913,6 @@ func (ec *ExecutionCollector) ExecutionScriptExecuted(dur time.Duration, compUse // ExecutionCallbacksExecuted reports callback execution metrics func (ec *ExecutionCollector) ExecutionCallbacksExecuted(callbackCount int, processComputationUsed, executeComputationLimits uint64) { ec.callbacksExecutedCount.Observe(float64(callbackCount)) - ec.callbacksExecutedTotal.Add(float64(callbackCount)) ec.callbacksProcessComputationUsed.Observe(float64(processComputationUsed)) ec.callbacksExecuteComputationLimits.Observe(float64(executeComputationLimits)) }