add rules and templates #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmymmit
approved these changes
Apr 20, 2020
LICENSE
Outdated
| MIT License |
There was a problem hiding this comment.
Why did we add MIT and remove apache?
|
@laynelafrance you're looking at an outdated commit. MIT was removed in |
joshuahannan
added a commit
that referenced
this pull request
Jun 16, 2022
* Traits view (#1) * Traits view * remove null check * tidy * Rarities (#3) * added rarity * reworded text * make test * Update contracts/MetadataViews.cdc Co-authored-by: Satyam Agrawal <satyam0499@gmail.com> * fix assertion in Rarities * spacing * tidy Co-authored-by: Bjarte Stien Karlsen <bjarte@bjartek.org> Co-authored-by: Satyam Agrawal <satyam0499@gmail.com> * Update contracts/MetadataViews.cdc Co-authored-by: Joshua Hannan <joshua.hannan@dapperlabs.com> * Feedback - Add a wrapper struct around an array of traits and assign to resolver type - Add test for rarity on a trait - Add test for display on a trait * cleanup * rename traitType to name * add an optional max to rarity * Apply suggestions from code review Co-authored-by: Peter Siemens <peterjsiemens@gmail.com> Co-authored-by: Bjarte Stien Karlsen <bjarte@bjartek.org> Co-authored-by: Satyam Agrawal <satyam0499@gmail.com> Co-authored-by: Joshua Hannan <joshua.hannan@dapperlabs.com> Co-authored-by: Peter Siemens <peterjsiemens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CODEOWNERS, contribution guidelines, code of conduct, license, copyright notice, and issue templates