ongo/facebook-ios-sdk forked from facebook/facebook-ios-sdk

…ation. Fixed warnings

Summary: urlSchemeSuffix is more descriptive and easier to grok than
localAppId.

Warning: This changes breaks compatibility with the previous version of the SDK. Please update your code to use the latest method signature.

Test Plan: compiled and ran the demo app with a urlSchemeSuffix configured

Reviewers: brent, lshepard, teck

Reviewed By: lshepard

CC: brent, lshepard

Differential Revision: 334704

Task ID: 737701

The original behavior is the correct behavior as it prevents random errors from popping up the inline login dialog.

Fallback to inline authentication dialog if SSO login fails.

…allback to the inline authentication dialog in -[Facebook handleOpenURL:]

Summary: The expireSession call was put in as a precaution to make sure that
apps sessions were really no longer good. However, this is unnecessary and it
causes issues with apps that were expecting the session to remain usable even
after the user logged out. So let's remove this call and leave it up to the app
developer to expire the session if they want.

Test Plan: Logged in and out of the demo app.

Reviewed By: trvish

…gate changes. Add notice on issue reporting.

Summary: The change basically just sets the session delegate in the constructor so
it's available when handleOpenUrl is called.

Test Plan: Ran the DemoApp and ensured SSO still works.

Reviewed By: toddkrabach

Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy

Differential Revision: 297414
Task ID: 653835

Summary:
Edited uploadPhoto to use requestWithGraphPath instead of the legacy REST api
requestWithMethodName method. Also added the publish_stream permission, which
is
needed for uploading photos.

Test Plan:
Run the DemoApp and login. Click the upload button and verify that a photo was
uploaded to the user's Facebook account (pending approval).

Reviewed By: yariv
Reviewers: yariv
CC: yariv
Differential Revision: 257551

Summary:
This is the SDK diff to support the local_client_id URL parameter that we added
to the FB app. I named it 'localAppId' to be consistent with the 'appId'
parameter to the same function.

Test Plan:
bound the demo app to 'fb1234foo' and passed 'foo' as the localAppId value.
verified the SDK used the 'fbauth2' url scheme to open the fb app and that the
fb app successfully redirected back to the demo app.

Reviewed By: brent
Reviewers: lshepard, atishm, brent, oyamauchi, jimbru
CC: brent
Differential Revision: 211201

…e 4.

The request: selectors in the Facebook class now return a pointer to the
instantiated FBRequest object (rather than void). This makes it easier
to know in the delegate callback which request the callback maps to.

Updated the dialog() method to always include app_id. This will prevent
an error if a dialog is requested and the application doesn't have an
access token. App_id must now be specified in the Facebook constructor
as this saves specifying it with every request. Xcode project has been
updated to build with iOS SDK 4.3.

Summary:
see https://github.com/facebook/facebook-ios-sdk/issues#issue/161

Test Plan:
verified it was called only once

DiffCamp Revision: 186903
Reviewed By: brent
CC: brent
Revert Plan:
OK

Summary:
Currently if the facebook app encounters a UIWebViewDelegate error, it passes
it to the sdk in the error_code parameter. The SDK should know that if this
parameter is passed, an error occurred, which implies the user *didn't* cancel.
This fixes it.

Test Plan:
disconnected my laptop from the internet, went through the sso flow, verified
the sdk set userDidCancel to NO before calling [self
fbDialogNotLogin:userDidCancel].

DiffCamp Revision: 180310
Reviewed By: brent
CC: brent
Revert Plan:
OK

Summary:
Edits to the documentation for clarity and grammar. This brings
documentation more in line with Android SDK for consistency.

Reviewers:
yariv

CC:
arunv, brent, lshepard

Test Plan:
All comments--no impact on code.

DiffCamp Revision: 179248

Summary:
It wasn't particularly useful, so it gets the rm -rf.

Test Plan:
Nothing depended on this, so we're good.

DiffCamp Revision: 179177
Reviewed By: yariv
CC: arunv, lshepard, brent, rmcelroy, arice, achao, yariv, bootcamp-diffs@lists
Tasks:
#431037: Go start-to-finish through iOS SDK and validate

Revert Plan:
OK

Summary: n/a

Task ID: #

Blame Rev:

Reviewers: brent, jbrusstar, lshepard, arunv

CC:

Test Plan: verified login via SSO worked

Revert Plan:

Tags:

- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -

DiffCamp Revision: 179100

Summary:
This diff implements single sign-on for iOS.

Test Plan:
n/a

DiffCamp Revision: 179082
Reviewed By: brent
CC: brent, arice, yariv
Revert Plan:
OK

… the app.

Summary:
The app before showed all your friends regardless of if they were using this
app.

With this diff, only friends who are or have used the app will be shown in the
list.

Test Plan:
Run the app with an app id which only some of your friends are using and only
those friends should show in the friends list.

DiffCamp Revision: 169803
Reviewed By: brent
CC: brent
Revert Plan:
OK

summary:
Fix some memory leak and dealloc issues

The Facebook.m -logout: method calls this:

[self requestWithMethodName:@"auth.expireSession"
andParams:params andHttpMethod:@"GET"
andDelegate:self];

By setting the Facebook object as the delegate, it gets retained by the FBRequest object, but in turn the -openUrl:params:httpMethod:delegate: method retains the request itself in the _request instance variable. This creates a retain cycle, and neither object will be freed.

-in Session.m, there is a missing retain on the uid in -restore -in Session.m there is no dealloc method — one should be added to free facebook and uid -in UserInfo.m, the dealloc needs to release the userInfoDelegate that was retained -in UserRequestResult.m there is no dealloc — one should be added to free userRequestDelegate

test plan:
theRunAroundDemoApp, open the app login and turn off the app without log out. bring the app up again. make sure we are logged in and all the session info bring back correctly.

Run the unittest