Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve $types parameters #800

Merged
merged 1 commit into from Jul 31, 2017
Merged

Conversation

nibsirahsieu
Copy link
Contributor

@nibsirahsieu nibsirahsieu commented Jul 24, 2017

According to the docs,

$search = new Search();
$search->addQuery(new TermQuery('title', 'Indiana'));

$results = $manager->search(
    // Array of documents representing different types
    ['AppBundle:City', 'AppBundle:State'], 
    $search->toArray()
);

but, those $types remains unresolved.

@saimaz saimaz merged commit bf49352 into ongr-io:master Jul 31, 2017
@nibsirahsieu nibsirahsieu deleted the search_resolve_types branch August 2, 2017 08:35
@nibsirahsieu
Copy link
Contributor Author

Hi @saimaz , Do you think it could be possible to backport it on the 5.0.x?

@saimaz
Copy link
Member

saimaz commented Nov 8, 2017

I think yes. Let me try to cherry-pick the commit from this PR and see how the test work.

@nibsirahsieu
Copy link
Contributor Author

Thank you

@saimaz
Copy link
Member

saimaz commented Nov 8, 2017

It's already in 5.0 branch.

@nibsirahsieu
Copy link
Contributor Author

Hi @saimaz , i'm sorry, but i can't see it on 5.0 branch.. it's on master branch (5.1-dev)

@saimaz
Copy link
Member

saimaz commented Nov 8, 2017

Sorry my bad, somehow my local branches was not in a sync with the remote. Just created a PR with a cherry-picked commit from here: #824

@nibsirahsieu
Copy link
Contributor Author

Thank you @saimaz

saimaz pushed a commit that referenced this pull request Mar 22, 2018
saimaz pushed a commit that referenced this pull request Jul 20, 2018
* Make ObjectIterator compatible with Doctrine Collections (#777)

Replace the custom hydration logic with an implementation of AbstractLazyCollection that will hydrate the full list of items prior to any action taken on the collection.

* Fixed undefined execute method (#799)

* [Doc] rename 'delete' -> 'remove' (#801)

* fixed #802 (#805)

* Optmize finOneBy methode (#798)

* Resolve $types parameters (#800)

* Collection needs to be used (#811)

I tried to use ArrayCollection, like said in the docs but this was not working...

* explicitly register commands as services, so that support Symfony 4 (#835)

* explicitly register commands as services, so that support Symfony 4

* rollback .gitignore

* rename Object class to ObjectType, fix mentions of it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants