allow runway tests to exit 0 without signaling failure #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will check the exit code of tests so any that have called sys.exit(0) (e.g. yamllint) won't trigger Runway to count it as failed.
ITProKyle
reviewed
Jun 29, 2020
runway/commands/runway/test.py
Outdated
| @@ -78,6 +78,8 @@ def execute(self): | |||
| # tool it is wrapping. | |||
| if not isinstance(err, SystemExit): | |||
| traceback.print_exc() | |||
| elif err.code == 0: | |||
| next # Tests calling sys.exit(0) don't indicate failure | |||
There was a problem hiding this comment.
I think you are looking for continue here
Suggested change
| next # Tests calling sys.exit(0) don't indicate failure | |
| continue |
This reverts commit 4452661.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check the exit code of tests so any that have called sys.exit(0) (e.g. yamllint) won't trigger Runway to count it as failed.