Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from UNIVERSAL::require to Module::Load #13

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
1 participant
@Songmu
Copy link
Collaborator

commented Jan 28, 2019

The UNIVERSAL::require was popular for a while, but it has gone old because it globally overwrites the namespace so it is not recommended now.

The Module::Load is a core module on Perl 5.10 or later and has fewer side effects.

There is a risk that it will not work in an environment where UNIVERSAL::require is expected but not loaded. But from the fact that the Devel::KYTProf is used in a production environment from AWS::XRay etc., so I think that this change is reasonable.

@Songmu Songmu changed the title [WIP] switch from UNIVERSAL::require to Module::Load switch from UNIVERSAL::require to Module::Load Jan 28, 2019

@Songmu

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 28, 2019

Please review @onishi .

It is okay to give me the commit bit and CPAN maintenance right.

@Songmu Songmu merged commit f01e837 into onishi:master Jan 29, 2019

@Songmu Songmu deleted the Songmu:module-load branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.