Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Reloading Oni via quick command with multiple windows causes oni split mode #1696

Closed
akinsho opened this issue Mar 2, 2018 · 1 comment
Closed

Comments

@akinsho
Copy link
Member

akinsho commented Mar 2, 2018

When using oni with multiple windows reloading one causes the newly reloaded oni session to blend with the first.

Steps to reproduce hopefully:

  1. Open an Oni window,
  2. Open a second oni window
  3. Select reload Oni in one window via Command palette

Outcome:
screen shot 2018-03-01 at 23 51 07

Oni attempts to reload the second window inside the first which opens as an oni split (the [WIP] oni split mode) but with duplicated sidebars.

Possible Cause:

The reload oni command in the CommandPalette has a reference to the first oni instance always so requesting a reload acts the same as trying to open a second oni instance which somehow triggers the code for the Oni split mode.

@oni-bot oni-bot bot added the insider label Mar 2, 2018
@akinsho akinsho added the bug label Mar 2, 2018
@akinsho
Copy link
Member Author

akinsho commented Mar 20, 2018

Seems to have been fixed by changes made in #1747

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant