This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Auto-Closing Pairs: Fix race condition on initial buffer enter #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initialized for very first buffer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Looking at automation logs, it seems that there are cases where auto-closing pairs may not be activated for the very first buffer. I believe this may be a 'real' issue, because I believe I have seen this when running via
npm run starttoo.Defect: The AutoClosingPairs service assumes that any
BufferEnterevent will come after it is initialized, but this actually isn't a guarantee - we may have passed a file for Neovim to open on startup, for example.Fix: When we activate auto closing pairs, if there is an active buffer currently, we should handle that too.