New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron to 2.0.8 to fix glibc version issue #2555

Merged
merged 1 commit into from Sep 8, 2018

Conversation

Projects
None yet
2 participants
@psxpaul
Contributor

psxpaul commented Sep 8, 2018

This should fix #2497, but I haven't encountered the issue on my Ubuntu machine as 18.04 is still on glibc 2.27.

@codecov

This comment has been minimized.

codecov bot commented Sep 8, 2018

Codecov Report

Merging #2555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2555   +/-   ##
=======================================
  Coverage   44.93%   44.93%           
=======================================
  Files         352      352           
  Lines       14336    14336           
  Branches     1863     1863           
=======================================
  Hits         6442     6442           
  Misses       7669     7669           
  Partials      225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af03770...f2d7107. Read the comment docs.

@Akin909

Akin909 approved these changes Sep 8, 2018

Thanks for upgrading this 👍

@Akin909 Akin909 merged commit bd94771 into onivim:master Sep 8, 2018

4 checks passed

codecov/patch Coverage not affected when comparing af03770...f2d7107
Details
codecov/project 44.93% remains the same compared to af03770
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@psxpaul psxpaul deleted the psxpaul:upgrade_electron branch Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment