This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Vertical Scrolling Is Here! (v2) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see extr0py is working on a scrolling optimisation branch, which is good. scrolling causes some matrix-effect level artifacting. I guess it's a new "feature" |
|
Awesome, thanks for the PR @bert88sta ! Looks great! Ya, regarding the artifacting - it's a 'feature' that the canvas is incrementally rendered, but ideally render would be fast enough that the 'incremental' isn't as necessary :) |
This was referenced Dec 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical scrolling with modifier keys is handled. I will do more work on horizontal later, but this is an essential part of an editor.