Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting for XML files appears to be broken #2332

Closed
synaptiqlabs opened this issue Aug 20, 2020 · 3 comments · Fixed by #2401
Closed

Syntax highlighting for XML files appears to be broken #2332

synaptiqlabs opened this issue Aug 20, 2020 · 3 comments · Fixed by #2401
Labels
A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request

Comments

@synaptiqlabs
Copy link

Buffers with only XML content for which the filetype has been set as XML have no syntax highlighting visible.

Version 0.5.1-nightly
Windows 10 Build 18362
@CrossR CrossR added A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request labels Aug 20, 2020
@CrossR
Copy link
Member

CrossR commented Aug 20, 2020

This is because we don't ship with XML syntax highlights built in (you can see the list in extensions/).

If you install an extension, either from finding a custom one, or installing the default VSCode one, it should work.

(Instructions here, if you wanted the default VSCode one, you'd want to copy extensions/xml from the VSCode git repo, and follow the manual install instructions).

@synaptiqlabs
Copy link
Author

Ah, understood. I guess I'll wait until the completion of VimL integration and see what can be done in the vein of Vim's XML ft plugin.

@CrossR
Copy link
Member

CrossR commented Aug 20, 2020

If you need XML highlights now, it should just be a case of

git clone https://github.com/microsoft/vscode.git
cp -r vscode/extensions/xml ~/.config/oni2/extensions/

@bryphe bryphe mentioned this issue Sep 3, 2020
Merged
bryphe added a commit that referenced this issue Sep 5, 2020
@bryphe
feat(extensions/#2332): Add XML extension
7a503d8 
We've had several requests for XML syntax highlighting. We still need a good automated way to pull extensions from VSCode - but in the meantime, I'll bring over the XML extension.

With this extension, XML syntax highlighting is available out of box:
![image](https://user-images.githubusercontent.com/13532591/92166326-4b9f8900-eded-11ea-923d-cb09ac994cd1.png)

Fixes #2332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-syntax-highlighting Area: Syntax Highlighting enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(extensions/#2332): Add XML extension onivim/oni2
2 participants
@CrossR @synaptiqlabs