Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Large edits cause syntax highlighting rainbows #550

Closed
airjp73 opened this issue Aug 2, 2019 · 5 comments
Closed

Bug: Large edits cause syntax highlighting rainbows #550

airjp73 opened this issue Aug 2, 2019 · 5 comments

Comments

@airjp73
Copy link

@airjp73 airjp73 commented Aug 2, 2019

I noticed a visual bug when deleting many lines at once. Something not shown in the gif here is, sometimes the syntax highlighting doesn't fully correct itself until making further edits.

Operating System: Windows
File in the Gif: On Github here
Command in the Gif: :g/*/d

2019-08-01_21-53-46

@bryphe
Copy link
Member

@bryphe bryphe commented Aug 2, 2019

Thanks for the issue, @airjp73 !

Indeed, syntax highlighting is one of our biggest performance bottlenecks at the moment. We're tracking moving to a native syntax highlighting here in #161 - most likely tree-sitter.

Loading

@CrossR
Copy link
Member

@CrossR CrossR commented Oct 23, 2019

If I'm remembering correctly, this was before the native tree-sitter and native textmate.

Is this still an issue now, or can this be closed out?

Loading

@airjp73
Copy link
Author

@airjp73 airjp73 commented Dec 9, 2019

I just downloaded the latest version on the website and it looks like the state of this issue has definitely improved. There's still some wonkiness but not the crazy rainbows there were when I reported the issue originally.
2019-12-09_13-25-56

Loading

@bryphe
Copy link
Member

@bryphe bryphe commented Dec 14, 2019

Thanks for the update @airjp73 !

We just merged #922 yesterday, which should improve this even further reduce that 'waterfall' effect you were seeing in the latest gif).

The next step for us is to switch to using more tree-sitter syntax highlighter!

Loading

@bryphe
Copy link
Member

@bryphe bryphe commented Dec 14, 2019

This should be fixed now by #771 (use native textmate highlighting) and #922 (asyncify the syntax highlighting) - so I'll close this out. Feel free to log a new issue if you are still seeing issues.

Thank you for reporting and for the update, @airjp73 !

Loading

@bryphe bryphe closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants