Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions/#2481): Fix blockers for vscode-spell-checker #2509

merged 8 commits into from Sep 26, 2020


Copy link

@bryphe bryphe commented Sep 24, 2020

There currently isn't a good spell-check solution for Onivim - the Vim spellcheck dictionaries are not currently integrated, and the vscode-spell-checker extension is blocked by a bug:


This fixes the blocking bug by implementing the missing $getLanguages API, which the code-spell-checker extension requires. In addition, we were treating all diagnostics as error-level severity in rendering, but spelling should come through as a lower severity - so this wires up the severity type to match the extension host's concept.

With this, the vscode-spell-checker extension works, and shows spell-checks alongside compilation errors:

Related to #2481

@bryphe bryphe merged commit eb4ed1b into master Sep 26, 2020
@bryphe bryphe deleted the fix/extensions/2481/vscode-spell-checker branch September 26, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant