fix(extension/#2593): TabNine extension won't install #2684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The TabNine extension won't install (gives error - Unable to locate extension) and isn't usable
Defect: There were two blocking issues:
null
value - this was what caused the error (after install, we parse the package.json to get some metadata for showing info about the extension).Fix:
null
/optional
value (Thanks @CrossR for the investigation!){ pattern: '**' }
so that it is triggered for all file types. However, we weren't recognizing this sort of selector - the second fix is to integrate glob pattern matching for these selectors.This unblocks the first round of issues - I think there may be still a couple bugs to investigate:
Related #2583