Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(completion/#2360): Add support for 'additionalTextEdits' #2712

merged 11 commits into from Nov 19, 2020


Copy link

@bryphe bryphe commented Nov 14, 2020

Issue: The 'auto-import' functionality in the TypeScript and Dart extensions is not working as expected (tracked in #2263

Defect: The suggest item coming from the extension host sends an additionalTextEdits property that we are not currently handling.

Fix: Handle the additionalTextEdits property when accepting a completion


  • Adjust cursor position based on the applied text edit
  • Fix completion staying open after applying completion w/ edit (language features think the cursor moved, applying completions again...)

Fixes #2360

@bryphe bryphe added the WIP label Nov 14, 2020
Copy link

Hi @bryphe, are we close to getting this fix merged for the next nightly release?

Copy link
Member Author

bryphe commented Nov 19, 2020

@Jorgee97 - getting close! Working for my test provider, at least:


Should make it in tomorrow's nightly

@bryphe bryphe removed the WIP label Nov 19, 2020
@bryphe bryphe merged commit 6bc0d35 into master Nov 19, 2020
@bryphe bryphe deleted the fix/completion/2360/additional-text-edit branch November 19, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Completions: Auto-import in typescript not working as expected
2 participants