Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions/#2723): Searching for "theme" fails with an error #2728

merged 5 commits into from Nov 21, 2020


Copy link

@bryphe bryphe commented Nov 17, 2020

Issue: When searching for extensions, some queries - like "theme" - will end up with an error message (Please check your n etwork connection).

Defect: Our JSON parser expects that the description field is required - but this is not a valid assumption. In the case of the "theme" query, there are some extensions that do not have a description field populated, causing the search results to break.

Fix: Make description optional, add test case.

Fixes #2723

Copy link

iwikal commented Nov 17, 2020

Perhaps one could also change the error handling so that parsing errors show some more accurate error message? "Internal error - please file an issue" perhaps.

@bryphe bryphe merged commit 0b6e636 into master Nov 21, 2020
@bryphe bryphe deleted the fix/extensions/2723/search-fails branch November 21, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Extension search fails
2 participants