fix(extensions/#2723): Searching for "theme" fails with an error #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps one could also change the error handling so that parsing errors show some more accurate error message? "Internal error - please file an issue" perhaps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When searching for extensions, some queries - like
"theme"- will end up with an error message (Please check your n etwork connection).Defect: Our JSON parser expects that the
descriptionfield is required - but this is not a valid assumption. In the case of the"theme"query, there are some extensions that do not have a description field populated, causing the search results to break.Fix: Make
descriptionoptional, add test case.Fixes #2723