fix(extensions): Extensions failing to download from open-vsx #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
added a commit
that referenced
this pull request
Dec 3, 2020
__Issue:__ Extensions are not downloading correctly from `open-vsx`. This impacts both installing from command-line, and within Onivim. __Defect:__ The `open-vsx` service updated their download service to be backed by azure blobs, and sends a 302 redirect - we weren't handling redirects in our download logic. __Fix:__ Handle redirects using the `follow-redirect` node module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Issue: Extensions are not downloading correctly from
open-vsx. This impacts both installing from command-line, and within Onivim.Defect: The
open-vsxservice updated their download service to be backed by azure blobs, and sends a 302 redirect - we weren't handling redirects in our download logic.Fix: Handle redirects using the
follow-redirectnode module.