fix(completion/#2583): Handle replace range after cursor #3276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Some completion providers, like TabNine, will give a replace range past the cursor, as well.
For example, in the completion case (where
|
is the cursor)app.get('/|')
Selecting a completion like
', (req, res) => {
would result in an extra'
at the end of the completion.Defect: We weren't utilizing the 'end' part of the insert / replace range
Fix: Use the end column of the insert/replace range to decide how many characters after the cursor to delete.
Related #2583