Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(completion/#2583): Handle replace range after cursor #3276

merged 7 commits into from Mar 16, 2021


Copy link

@bryphe bryphe commented Mar 15, 2021

Issue: Some completion providers, like TabNine, will give a replace range past the cursor, as well.

For example, in the completion case (where | is the cursor)

Selecting a completion like ', (req, res) => { would result in an extra ' at the end of the completion.

Defect: We weren't utilizing the 'end' part of the insert / replace range

Fix: Use the end column of the insert/replace range to decide how many characters after the cursor to delete.

Related #2583

@bryphe bryphe merged commit 6619930 into master Mar 16, 2021
@bryphe bryphe deleted the fix/completion/2583/overwrite-after branch March 16, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant