fix(completion/#3258): Rescript identifiers not completing with opened module #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
added a commit
that referenced
this pull request
Mar 22, 2021
…ases (#3309) __Issue:__ A combination of #3279 and #3298 caused a regression in keyword / snippet completion. In some cases, the keyword completion would work fine - but if there was a non-word trigger character in front, that character would be consumed by the insertion. __Defect:__ In #3279 , an `insertLocation` was added to the meet. This `insertLocation` is used for positioning the insertion. In #3298, the keywords/ snippets bake in an insert range - but from the `meet.location` instead of `meet.insertLocation`. The `meet.location` is incorrect in the situation described above, so it causes an incorrect insertion position. __Fix:__ Pass `meet.insertLocation` to the snippet / keyword providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: After opening a module (ie,
open Array), functions that are now exposed, likemaxwouldn't show up in completion.Defect: When typing (ie,
m|), the completion meet would be at position 0 - and querying the completions at position 0 for the rescript provider wouldn't return anything.Fix: In the case where a token is at the beginning of a line, or after a space, query after the first character - this gives better results and mimics the behavior of Code. In addition, keep track of a separate
insertLocationwhich built-in keywords and snippets can use to pick up the correct insertion range.Fixes #3258